Skip to content

add PLATFORMIO_CORE_DIR - #91

Open
stm32repo wants to merge 1 commit into
meshtastic:mainfrom
stm32repo:dev/add-platformio-core-dir
Open

stm32repo wants to merge 1 commit into
meshtastic:mainfrom
stm32repo:dev/add-platformio-core-dir

Conversation

@stm32repo

@stm32repo stm32repo commented Sep 18, 2026 •

Copy link
Copy Markdown

Summary by CodeRabbit

  • Bug Fixes
    • Improved build reliability by keeping PlatformIO’s core files within the package build directory.

@coderabbitai

coderabbitai Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 8c551b6c-e898-4565-8247-ac03b9c063ec

📥 Commits

Reviewing files that changed from the base of the PR and between fccc8b5 and 30d9622.

📒 Files selected for processing (1)
  • meshtasticd/Makefile

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The meshtasticd OpenWrt package Makefile adds PLATFORMIO_CORE_DIR to BUILD_FLAGS and sets it to .platformio within the package build directory.

Changes

PlatformIO build configuration

Layer / File(s) Summary
PlatformIO core directory setting
meshtasticd/Makefile
BUILD_FLAGS now includes PLATFORMIO_CORE_DIR="$(PKG_BUILD_DIR)/.platformio".

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: vidplace7

Merge Risk: ⚪ Minimal · up to 30d96

The build configuration change confines the PlatformIO core directory to the package build directory without identified merge-blocking impact.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly identifies the main change: adding the PLATFORMIO_CORE_DIR build flag. It is concise and clear.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit hops through builds so neat
The core now rests where paths meet
Inside the package tree
A tidy dot-directory
Makes PlatformIO complete

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants